Skip to content

Upgrade github/codeql dependency to 2.21.4 #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
github-actions wants to merge 4 commits into from
Open

Upgrade github/codeql dependency to 2.21.4 #1015

github-actions wants to merge 4 commits into from
+205 −178

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Jan 14, 2026 •
edited by MichaelRFairhurst
Loading

This PR upgrades the CodeQL CLI version to 2.21.4.

CodeQL dependency upgrade checklist:

  • Confirm the code has been correctly reformatted according to the new CodeQL CLI.
  • Identify any CodeQL compiler warnings and errors, and update queries as required.
  • Validate that the github/codeql test cases succeed.
  • Address any CodeQL test failures in the github/codeql-coding-standards repository.
  • Validate performance vs pre-upgrade, using /test-performance

@jeongsoolee09
Copy link
Collaborator

jeongsoolee09 commented Jan 14, 2026

/test-performance

@github-actions
Copy link
Author

github-actions bot commented Jan 14, 2026

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

@jeongsoolee09
Copy link
Collaborator

jeongsoolee09 commented Jan 14, 2026

/test-performance

@github-actions
Copy link
Author

github-actions bot commented Jan 14, 2026

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

@codeql-coding-standards-automation
Copy link

codeql-coding-standards-automation bot commented Jan 14, 2026

🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 


Release                            : v2.51.0
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2416350
Mean_Predicate_Execution_Time_Ms   : 48.50550024088646
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 490.5288675281087
Total_Serialized_Execution_Time_s  : 2416.35
Mean_Query_Execution_Time_s        : 0.0485055002408864
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 130.0
Number_of_Predicates               : 49816

Release                            : v2.51.0
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 2794293
Mean_Predicate_Execution_Time_Ms   : 60.56380857427717
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 539.5015947242475
Total_Serialized_Execution_Time_s  : 2794.293
Mean_Query_Execution_Time_s        : 0.0605638085742771
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 161.0
Number_of_Predicates               : 46138

Release                            : v2.51.0
Platform                           : x86-windows
Language                           : c
Total_Serialized_Execution_Time_Ms : 2881364
Mean_Predicate_Execution_Time_Ms   : 57.7335096577703
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 467.6514025697072
Total_Serialized_Execution_Time_s  : 2881.364
Mean_Query_Execution_Time_s        : 0.0577335096577703
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 179.0
Number_of_Predicates               : 49908

Release                            : v2.51.0
Platform                           : x86-windows
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 2810274
Mean_Predicate_Execution_Time_Ms   : 60.70361810130684
Median_Predicate_Execution_Time_Ms : 1.0
Standard_Deviation_Ms              : 376.3383909893097
Total_Serialized_Execution_Time_s  : 2810.274
Mean_Query_Execution_Time_s        : 0.0607036181013068
Median_Predicate_Execution_Time_s  : 0.001
Percentile95_Ms                    : 194.0
Number_of_Predicates               : 46295

Release                            : v2.52.0
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2384957
Mean_Predicate_Execution_Time_Ms   : 47.847467148159296
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 477.07267744579366
Total_Serialized_Execution_Time_s  : 2384.957
Mean_Query_Execution_Time_s        : 0.0478474671481592
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 129.0
Number_of_Predicates               : 49845

Release                            : v2.52.0
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 2797038
Mean_Predicate_Execution_Time_Ms   : 60.538017011882346
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 544.3872558673145
Total_Serialized_Execution_Time_s  : 2797.038
Mean_Query_Execution_Time_s        : 0.0605380170118823
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 157.0
Number_of_Predicates               : 46203

Release                            : v2.52.0
Platform                           : x86-windows
Language                           : c
Total_Serialized_Execution_Time_Ms : 2888929
Mean_Predicate_Execution_Time_Ms   : 57.89320855293481
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 460.3337357338445
Total_Serialized_Execution_Time_s  : 2888.929
Mean_Query_Execution_Time_s        : 0.0578932085529348
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 177.0
Number_of_Predicates               : 49901

Release                            : v2.52.0
Platform                           : x86-windows
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 3377346
Mean_Predicate_Execution_Time_Ms   : 73.12805300536982
Median_Predicate_Execution_Time_Ms : 1.0
Standard_Deviation_Ms              : 512.3568513191373
Total_Serialized_Execution_Time_s  : 3377.346
Mean_Query_Execution_Time_s        : 0.0731280530053698
Median_Predicate_Execution_Time_s  : 0.001
Percentile95_Ms                    : 225.0
Number_of_Predicates               : 46184

Release                            : 1015
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 2835328
Mean_Predicate_Execution_Time_Ms   : 60.750085704490914
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 543.9687633022305
Total_Serialized_Execution_Time_s  : 2835.328
Mean_Query_Execution_Time_s        : 0.0607500857044909
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 156.0
Number_of_Predicates               : 46672

Release                            : 1015
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2432242
Mean_Predicate_Execution_Time_Ms   : 48.3941582602121
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 502.323616757349
Total_Serialized_Execution_Time_s  : 2432.242
Mean_Query_Execution_Time_s        : 0.0483941582602121
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 129.0
Number_of_Predicates               : 50259

🏁 Below are the slowest predicates for the last 2 releases vs this PR. 


Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 32171

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 25555

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 29493

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 31154

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : OrderingPredicateMustBeStrictlyWeak::IsStrictlyWeaklyOrderedComment#07390086
Execution_Time_Ms : 19637

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : #select
Execution_Time_Ms : 20445

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : HardwareOrProtocolInterface::HardwareOrProtocolInterfaceComment#dbbd8a01
Execution_Time_Ms : 21000

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 31200

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : _Class::Class.getALinkTarget/0#dispred#29b2b38a#bf_Class::Class.getALinkTarget/0#dispred#29b2b38a#bf__#shared
Execution_Time_Ms : 24474

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 31966

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Class::Class.getALinkTarget/0#dispred#29b2b38a#bf_Class::Class.getALinkTarget/0#dispred#29b2b38a#bf__#shared
Execution_Time_Ms : 24328

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTable/5#79217c12
Execution_Time_Ms : 21542

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CheckedException::CheckedException#b0aa5ec8
Execution_Time_Ms : 26618

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : Dependency::dependsOnTransitive/2#cbda84a0
Execution_Time_Ms : 24622

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : let0
Execution_Time_Ms : 16468

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-linux
Language          : c
Suite             : cert-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTable/5#79217c12
Execution_Time_Ms : 22929

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : Dependency::dependsOnTransitive/2#cbda84a0
Execution_Time_Ms : 30254

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CharacterOutsideTheLanguageStandardBasicSourceCharacterSetUsedInTheSourceCode::getUniversalCharacterName/1#36dbaa42
Execution_Time_Ms : 26849

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 28546

Release           : v2.52.0
Run               : 2025-12-01_17-02-26
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : FunctionEquivalence::typeSig/1#194ac728
Execution_Time_Ms : 24237

Release           : 1015
Run               : 2026-01-14_21-48-53
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 32754

Release           : 1015
Run               : 2026-01-14_21-48-53
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 33276

Release           : 1015
Run               : 2026-01-14_21-48-53
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : #select
Execution_Time_Ms : 22602

Release           : 1015
Run               : 2026-01-14_21-48-53
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : VirtualDispatchPrototype::VirtualDispatch::cannotInheritHelper/4#7c75bd87
Execution_Time_Ms : 23217

Release           : 1015
Run               : 2026-01-14_21-48-53
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CharacterOutsideTheLanguageStandardBasicSourceCharacterSetUsedInTheSourceCode::getUniversalCharacterName/1#36dbaa42
Execution_Time_Ms : 33279

Release           : 1015
Run               : 2026-01-14_21-48-53
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 24642

Release           : 1015
Run               : 2026-01-14_21-48-53
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CheckedException::CheckedException#b0aa5ec8
Execution_Time_Ms : 26933

Release           : 1015
Run               : 2026-01-14_21-48-53
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 31170

Release           : 1015
Run               : 2026-01-14_21-48-53
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 30895

Release           : 1015
Run               : 2026-01-14_21-48-53
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Class::Class.getALinkTarget/0#dispred#29b2b38a#bf_Class::Class.getALinkTarget/0#dispred#29b2b38a#bf__#shared
Execution_Time_Ms : 28927

@MichaelRFairhurst MichaelRFairhurst self-requested a review January 15, 2026 04:15
@MichaelRFairhurst
Copy link
Collaborator

MichaelRFairhurst commented Jan 15, 2026

Performance looks good!

@jeongsoolee09 jeongsoolee09 added this pull request to the merge queue Jan 15, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelRFairhurst MichaelRFairhurst MichaelRFairhurst approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeongsoolee09 @MichaelRFairhurst @IdrissRio @jketema